Re: [PATCH 1/2] generic/68[12]: use the dir blocksize for xfs filesystems

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On 2024-02-01 17:17:31, Anthony Iliopoulos wrote:
> The tests are using the filesystem block size for calculating the number
> of dirents required to fill a 2-block directory. For v4 xfs filesystems
> formatted with fs blocksize of 512 bytes this is failing, as the tests
> do not take into account that the directory block size is not always
> equal to the filesystem block size. As such, the tests never go over
> quota, and even if they did there is no hard block limit being set (due
> to 512 / 1024 = 0 calculation in setquota).
> 
> Use the directory blocksize instead of the filesystem blocksize, when
> the fstype under test is xfs.
> 
> Signed-off-by: Anthony Iliopoulos <ailiop@xxxxxxxx>
> ---

LGTM
Reviewed-by: Andrey Albershteyn <aalbersh@xxxxxxxxxx>

-- 
- Andrey





[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux