On 22.01.24 13:26, David Disseldorp wrote:
>> +# This issue is fixed by the following kernel patch:
>> +# btrfs: zoned: wake up cleaner sooner if needed
>
> To-be-queued fixes are often flagged in the test via:
> _fixed_by_kernel_commit XXXXXXXXXXXX \
> "btrfs: zoned: wake up cleaner sooner if needed"
OK will update.
>
>> +
>> +. ./common/preamble
>> +_begin_fstest auto enospc rw zone
>> +
>> +# real QA test starts here
>> +
>> +_supported_fs btrfs
>
> I don't see anything btrfs specific here, aside from the actual bug
> being triggered.
> Would it make sense to move this to generic, or would that be a waste of
> cycles for non-zone envs?
Of cause it could, I'm not sure how beneficial this is to other FSes
though. TBH I'm not aware of any generic test that specifically targets
issues related to zoned devices, which doesn't mean that it shouldn't.
I'm totally fine either way.
>> +_require_scratch
>> +_require_zoned_device "$SCRATCH_DEV"
>> +
>> +devsize=$(cat /sys/block/$(_short_dev $SCRATCH_DEV)/size)
>> +devsize=$(expr $devsize \* 512)
>> +filesize=$(expr $devsize \* 60 / 100)
>> +
>> +fio_config=$tmp.fio
>> +
>> +# Override the default cleanup function.
>> +_cleanup()
>> +{
>> + rm -f $tmp.*
>> +}
>
> nit: looks like there's no need to override the default cleanup.
Oops.
