Re: [PATCH] README: add a missing necessary package

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Thu, 4 Jan 2024 16:41:08 +0800, Zorro Lang wrote:

> On Thu, Jan 04, 2024 at 01:42:36PM +0800, Chung-Chiang Cheng wrote:
> > src/dbtests.c requires 'gdbm-ndbm.h' or 'ndbm.h', both of which are
> > supplied by 'libgdbm-compat-dev' in the latest Ubuntu LTS. However,
> > this package is not a dependency of the currently listed packages.
> > Therefore, add it explicitly to the necessary packages list.
> > 
> > $ dpkg -L libgdbm-compat-dev
> > /.
> > /usr
> > /usr/include
> > /usr/include/dbm.h
> > /usr/include/gdbm-ndbm.h
> > /usr/include/ndbm.h
> > 
> > Signed-off-by: Chung-Chiang Cheng <cccheng@xxxxxxxxxxxx>
> > ---
> >  README | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/README b/README
> > index e0dabe96503a..c46690c4eabb 100644
> > --- a/README
> > +++ b/README
> > @@ -11,7 +11,8 @@ Ubuntu or Debian
> >     $ sudo apt-get install acl attr automake bc dbench dump e2fsprogs fio gawk \
> >          gcc git indent libacl1-dev libaio-dev libcap-dev libgdbm-dev libtool \
> >          libtool-bin liburing-dev libuuid1 lvm2 make psmisc python3 quota sed \
> > -        uuid-dev uuid-runtime xfsprogs linux-headers-$(uname -r) sqlite3
> > +        uuid-dev uuid-runtime xfsprogs linux-headers-$(uname -r) sqlite3 \
> > +        libgdbm-compat-dev  
> 
> Oh, We call it "gdbm-devel" in Fedora. Thanks for this updating for Debian!
> 
> Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>

While you're there, please feel free to collapse in:

--- a/README
+++ b/README
@@ -76,7 +76,8 @@ SUSE Linux Enterprise or openSUSE
 
    $ sudo zypper install acct automake bc dbench duperemove dump fio gcc git \
         indent libacl-devel libaio-devel libattr-devel libcap libcap-devel \
-        libtool liburing-devel libuuid-devel lvm2 make quota sqlite3 xfsprogs
+        libtool liburing-devel libuuid-devel lvm2 make quota sqlite3 xfsprogs \
+        gdbm-devel

Reviewed-by: David Disseldorp <ddiss@xxxxxxx>

Thanks, David




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux