Re: [PATCH] fstests: filter.btrfs: update _filter_transaction_commit()

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Fri, 15 Dec 2023 12:09:51 +0900, Naohiro Aota wrote:
...
> diff --git a/common/filter.btrfs b/common/filter.btrfs
> index 02c6b92dfa94..cea9911448eb 100644
> --- a/common/filter.btrfs
> +++ b/common/filter.btrfs
> @@ -70,6 +70,7 @@ _filter_btrfs_device_stats()
>  
>  _filter_transaction_commit() {
>  	sed -e "/Transaction commit: none (default)/d" | \
> +	sed -e "s/Delete subvolume [0-9]\+/Delete subvolume/g" | \
>  	sed -e "s/Delete subvolume (.*commit):/Delete subvolume/g"
>  }
>  


Looks fine
Reviewed-by: David Disseldorp <ddiss@xxxxxxx>

Nit: the pipe chain can be removed. It might also be a little simpler
if each version had an independent filter, e.g.
  sed -e "/Transaction commit: none (default)/d" \
      -e "s/Delete subvolume [0-9]\+ (.*commit)/Delete subvolume/g" \
      -e "s/Delete subvolume (.*commit):/Delete subvolume/g"




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux