On Wed, Nov 01, 2023 at 02:17:13PM -0400, Jeff Layton wrote: > With NFS in particular, we are usually testing with some mount options. > Ensure that we preserve those and just add "nosharecache" onto the end > of the string. > > Cc: Yongcheng Yang <yoyang@xxxxxxxxxx> > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx> > --- > tests/generic/732 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/generic/732 b/tests/generic/732 > index 785aac58f361..ae49152e42dc 100755 > --- a/tests/generic/732 > +++ b/tests/generic/732 > @@ -40,7 +40,7 @@ mkdir -p $testdir1 $testdir2 > # Don't share the data and attribute caches among mount points for NFS. > # This caching behavior is necessary to reproduce this issue as we're > # checking the alignment of each mount point's own unique cache. > -[ "$FSTYP" = "nfs" ] && MOUNT_OPTIONS="-o nosharecache" > +[ "$FSTYP" = "nfs" ] && MOUNT_OPTIONS="$MOUNT_OPTIONS -o nosharecache" Good to me, and looks like the later option replaces the former one, if there're same options (e.g. -o sharecache -o nosharecache). Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx> > > SCRATCH_MNT=$testdir1 _scratch_mount > SCRATCH_MNT=$testdir2 _scratch_mount > > --- > base-commit: 59299b65ac8f15935ab45e7920cbfda8a6beffd1 > change-id: 20231101-master-328ff30ce66f > > Best regards, > -- > Jeff Layton <jlayton@xxxxxxxxxx> > >
