Re: [PATCH 1/2] xfs/556: call _require_dm_target later

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Mon, Oct 16, 2023 at 03:11:02PM +0200, Christoph Hellwig wrote:
> _require_dm_target tries to use $SCRATCH_DEV, so move it after we've
> established that the configuration has a valid $SCRATCH_DEV.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Oops, thanks for catching that.
Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>

--D

> ---
>  tests/xfs/556 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/556 b/tests/xfs/556
> index 66908a54..061d8d57 100755
> --- a/tests/xfs/556
> +++ b/tests/xfs/556
> @@ -25,10 +25,10 @@ _cleanup()
>  
>  # real QA test starts here
>  _supported_fs xfs
> -_require_dm_target error
>  _require_scratch
>  _require_scratch_xfs_crc
>  _require_scrub
> +_require_dm_target error
>  
>  filter_scrub_errors() {
>  	_filter_scratch | sed \
> -- 
> 2.39.2
> 



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux