[PATCH] common/rc: check error case and fail the test

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



If we place /var/lib/xfstests on a read-only filesystem, commands in
_link_out_file_named() fail to modify the files. However, they won't fail
the test. As a result, the test case fails mysteriously with only "no
qualified output" printed.

Fix it by checking the error case.

Signed-off-by: Naohiro Aota <naohiro.aota@xxxxxxx>
---
 common/rc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/rc b/common/rc
index 76a7e7740318..4e9bd34f7772 100644
--- a/common/rc
+++ b/common/rc
@@ -3431,8 +3431,8 @@ _link_out_file_named()
 		}
 		print $result
 		' <$seqfull.cfg)
-	rm -f $1
-	ln -fs $(basename $1).$suffix $1
+	rm -f $1 || _fail "_link_out_file_named: failed to remove existing output file"
+	ln -fs $(basename $1).$suffix $1 || _fail "_link_out_file_named: failed to setup output file"
 }
 
 _link_out_file()
-- 
2.42.0




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux