Re: [PATCH] btrfs/076: fix file_size variable

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Mon, Sep 25, 2023 at 5:34 AM Naohiro Aota <naohiro.aota@xxxxxxx> wrote:
>
> The file size written below is 10 MB, but the variable is set to 1 MB. Fix
> it, or the test will fail.
>
> Signed-off-by: Naohiro Aota <naohiro.aota@xxxxxxx>

Reviewed-by: Filipe Manana <fdmanana@xxxxxxxx>

Ok, so this means that v3 of the recent patch:

https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/commit/?h=for-next&id=f4c7dbbb4f166996d8fefdebbceacd2f7d359dee

was completely untested and now the test always fails. Too bad.

Thanks for the fix.

> ---
>  tests/btrfs/076 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/btrfs/076 b/tests/btrfs/076
> index 23f9bd534a0a..894a1ac7fa5d 100755
> --- a/tests/btrfs/076
> +++ b/tests/btrfs/076
> @@ -37,7 +37,7 @@ if _scratch_btrfs_is_zoned; then
>                 max_extent_size=$(( $zone_append_max / 4096 * 4096 ))
>         fi
>  fi
> -file_size=$(( 1 * 1024 * 1024 ))
> +file_size=$(( 10 * 1024 * 1024 ))
>  expect=$(( (file_size + max_extent_size - 1) / max_extent_size ))
>
>  _scratch_mkfs >> $seqres.full 2>&1
> --
> 2.42.0
>




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux