Re: [PATCH v3] btrfs: Add test for the temp-fsid feature

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On 16/09/2023 20:35, Guilherme G. Piccoli wrote:
On 15/09/2023 20:25, Anand Jain wrote:
[...]
This test case's integration will be timed alongside the kernel.

Running this test case on older kernel/progs without the feature under
test must terminate the test case with _notrun(). I find that part is
missing here.


I'm confused about the relation between _notrun() and
_require_btrfs_fs_feature(). I see that some tests (like mine) make use
of the latter, but some tests do as you suggest, using _notrun. They
intersect only on tests 125 and 192, and it seems they are aimed at
different things, based on these two.

The _require_btrfs_fs_feature() seems to be used with the same semantic
I'm using, i.e., to check if a feature is present, given that the test
requires it. Now the _notrun() thing is used like (in test 192):


+_require_btrfs_mkfs_feature temp-fsid
+_require_btrfs_fs_feature temp_fsid

This will suffice for backward compatibility. My bad. I missed it.


# We require a 4K nodesize to ensure the test isn't too slow
if [ $(_get_page_size) -ne 4096 ]; then
         _notrun "This test doesn't support non-4K page size yet"
fi


So, there's a secondary condition here, and the test is prevented from
running if such condition is not achieved.

Do you / others think I should switch approaches and use _notrun()? Or
should I somehow use both?!

We don't need this because the temp_fsid feature is compatible with other page/sector sizes.


+_scratch_dev_pool_put 1

_scratch_dev_pool_put

takes no argument.

Thanks for noticing that! Will fix in next version =)

No worries. If this is the only change required, it can be fixed during the merge.

Thanks, Anand

Cheers!




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux