On Wed, Sep 06, 2023 at 03:13:49PM +0800, Shiyang Ruan wrote:
> Some test cases lack executable permission ('x'). Before running each
> test case, `./check` checks and grants them 'x' permission. However,
> this always leads to a dirty git repo. And the absence of 'x' permission
> in test cases is often overlooked during reviews.
>
> Since maintainers use mvtest to assign new case, add this change for
> convenience of maintainers.
>
> Signed-off-by: Shiyang Ruan <ruansy.fnst@xxxxxxxxxxx>
> ---
> tools/mvtest | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/mvtest b/tools/mvtest
> index 99b154142..e839f0256 100755
> --- a/tools/mvtest
> +++ b/tools/mvtest
> @@ -28,6 +28,8 @@ append() {
> test "${src}" != "${dest}" || die "Test \"${src}\" is the same as dest."
> test -e "tests/${src}" || die "Test \"${src}\" does not exist."
> test ! -e "tests/${dest}" || die "Test \"${src}\" already exists."
> +# make sure testcase is executable
> +test `stat -c '%a' tests/${src}` == 755 || chmod 755 "tests/${src}"
I think we can check and set the file permission on the target file after the
move operation done, not the source file.
And we recommend using $() to replace ``, if both of them work.
Thanks,
Zorro
>
> sid="$(basename "${src}")"
> did="$(basename "${dest}")"
> --
> 2.42.0
>
