Re: [PATCH] btrfs/282: skip test if /var/lib/btrfs isnt writable

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]




  _require_scratch_size $(( 5 * 1024 * 1024))
+# Make sure we can create scrub progress data file
+if [ -e /var/lib/btrfs ]; then
+    test -w /var/lib/btrfs || _notrun '/var/lib/btrfs is not writable'
+else
+    test -w /var/lib || _notrun '/var/lib/btrfs cannot be created'
+fi
+

We need to enhance this to  a common helper, as there are many test
cases with the scrub command in them. I'll enhance it.

Hmm. No, for all the remaining test cases that use btrfs scrub start,
the output and its stderr are redirected to seqres.full. So, those test
cases will still pass. And, btrfs/282"is the only test case that
requires scrub status.

Thanks, Anand


However, for now, this patch is fine has been applied locally with
commit log changes.

Reviewed-by: Anand Jain <anand.jain@xxxxxxxxxx>


  _scratch_mkfs >> $seqres.full 2>&1
  _scratch_mount





[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux