On Tue, Aug 22, 2023 at 04:28:51PM +0900, Naohiro Aota wrote:
> When short read or corruption happened, it is difficult to locate which IO
> event failed. Print the address to make it identifiable.
>
> Signed-off-by: Naohiro Aota <naohiro.aota@xxxxxxx>
> ---
Good to me,
Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>
> src/aio-dio-regress/aio-dio-write-verify.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/src/aio-dio-regress/aio-dio-write-verify.c b/src/aio-dio-regress/aio-dio-write-verify.c
> index 90e41b391289..dabbfacde3f8 100644
> --- a/src/aio-dio-regress/aio-dio-write-verify.c
> +++ b/src/aio-dio-regress/aio-dio-write-verify.c
> @@ -267,13 +267,14 @@ static int io_verify(int fd)
> perror("pread");
> return 1;
> } else if (sret != p->param->buf_size) {
> - fprintf(stderr, "short read %zd was less than %zu\n",
> - sret, p->param->buf_size);
> + fprintf(stderr, "short read %zd was less than %zu at %zu\n",
> + sret, p->param->buf_size, p->param->offset);
> return 1;
> }
> if (memcmp(p->param->buf,
> p->param->cmp_buf, p->param->buf_size)) {
> - printf("Find corruption\n");
> + printf("Find corruption at %zu length %zu\n", p->param->offset,
> + p->param->buf_size);
> dump_buffer(p->param->buf, p->param->offset,
> p->param->buf_size);
> corrupted++;
> --
> 2.41.0
>
