On 2023/7/27 23:50, Zorro Lang wrote:
On Mon, Jul 24, 2023 at 11:04:23AM +0800, Qu Wenruo wrote:
The test case itself is utilizing RAID5/6, which is not yet supported on
zoned device.
In the future we would use raid-stripe-tree (RST) feature, but for now
just reject zoned devices completely.
And since we're here, also update the _fixed_by_kernel_commit lines, as
the proper fix is already merged upstream.
Signed-off-by: Qu Wenruo <wqu@xxxxxxxx>
---
Just check before next fstests release. This patch has been reviewed, but looks
like there're still more review points from btrfs list. So will you send a new
version to replace this patch?
IMHO the patch is fine to be merged for now.
The new comments are mostly a future work idea, which needs some time to
develop and extra kernel features.
Thanks,
Qu
Thanks,
Zorro
tests/btrfs/294 | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tests/btrfs/294 b/tests/btrfs/294
index 61ce7d97..d7d13646 100755
--- a/tests/btrfs/294
+++ b/tests/btrfs/294
@@ -16,11 +16,15 @@ _begin_fstest auto raid volume
# Modify as appropriate.
_supported_fs btrfs
+
+# No zoned support for RAID56 yet.
+_require_non_zoned_device "${SCRATCH_DEV}"
+
_require_scratch_dev_pool 8
_fixed_by_kernel_commit a7299a18a179 \
"btrfs: fix u32 overflows when left shifting @stripe_nr"
-_fixed_by_kernel_commit xxxxxxxxxxxx \
- "btrfs: use a dedicated helper to convert stripe_nr to offset"
+_fixed_by_kernel_commit cb091225a538 \
+ "btrfs: fix remaining u32 overflows when left shifting stripe_nr"
_scratch_dev_pool_get 8
--
2.41.0
