On Sun, Jul 23, 2023 at 12:50:17PM +0800, Zorro Lang wrote: > I'd like to help this patchset to catch this or next fstests release. So I > changed this patch a bit, if you feel good, I'll merge this patch as below. > (Same to the 2nd patch). I've actually got a few other changes locally nad plant to send it out. > Change logs: > 1) Replace SCRATCH_DEV with TEST_DEV, replace SCRATCH_MNT with SCSI_DEBUG_MNT > which is a directory in TEST_DIR, due to we don't call _require_scratch > in this case. The SCSI_DEBUG_MNT change is fine. The SCRATCH_DEV stuff I think we don't need at all, after all the sector size doesn't really matter for this test, so I've just dropped it. > 2) Call _fail if _mkfs_dev or _mount fails Shouldn't the mkfs side also use run_check ? Btw, your cleanups should also go into generic/108 from where I took the scsi_debug boilerplate. I'll resend later today, also incorporating your changes.
