Re: [PATCH RFC] common/btrfs: use _scratch_cycle_mount to ensure all page caches are dropped

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]





On 2023/6/8 20:15, Christoph Hellwig wrote:
On Thu, Jun 08, 2023 at 07:48:36PM +0800, Qu Wenruo wrote:
  	echo 3 > /proc/sys/vm/drop_caches
+	# Above drop_caches doesn't seem to drop every pages on aarch64 with
+	# 64K page size.
+	# So here as a workaround, cycle mount the SCRATCH_MNT to ensure
+	# the cache are dropped.
+	_scratch_cycle_mount

The _scratch_cycle_mount looks ok to me, but if we do that, there is
really no point in doing the drop_caches as well.

Yep, we can remove that line. It's mostly a reminder for me to dig out why that drop_caches doesn't work as expected.

Thanks,
Qu



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux