From: Darrick J. Wong <djwong@xxxxxxxxxx>
Change this helper to require the caller to pass the value as the second
parameter. This prepares us to start reporting a lot more information
about a test run, not all of which are encoded as bash variables.
Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
---
common/report | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/common/report b/common/report
index 3ec2d88178..2ab83928db 100644
--- a/common/report
+++ b/common/report
@@ -29,12 +29,13 @@ encode_cdata()
_xunit_add_property()
{
local name="$1"
- local value="${!name}"
+ local value="$2"
- if [ ! -z "$value" ]; then
- echo -e "\t\t<property name=\"$name\" value=\"$value\"/>"
- fi
+ test -z "$value" && return
+
+ echo -e "\t\t<property name=\"$name\" value=\"$value\"/>"
}
+
_xunit_make_section_report()
{
# xfstest:section ==> xunit:testsuite
@@ -76,7 +77,7 @@ ENDL
# Properties
echo -e "\t<properties>" >> $REPORT_DIR/result.xml
for p in "${REPORT_ENV_LIST[@]}"; do
- _xunit_add_property "$p"
+ _xunit_add_property "$p" "${!p}"
done | sort >> $REPORT_DIR/result.xml
echo -e "\t</properties>" >> $REPORT_DIR/result.xml
if [ -f $report ]; then
