Re: [PATCH] btrfs/286: add missing calls to _scratch_dev_pool_put and _spare_dev_put

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

On 07/03/2023 19:38, fdmanana@xxxxxxxxxx wrote:
From: Filipe Manana <fdmanana@xxxxxxxx>

The test is doing a _scratch_dev_pool_get, which shrinks the list of
devices in SCRATCH_DEV_POOL, but it's not calling _scratch_dev_pool_put
before it finishes. This will result in subsequent tests (none at the
moment however) getting a reduced list of devices in SCRATCH_DEV_POOL.

The same goes for the spare device, the test calls _spare_dev_get but
it never calls _spare_dev_put.

So add the missing calls.

Signed-off-by: Filipe Manana <fdmanana@xxxxxxxx>
  tests/btrfs/286 | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/tests/btrfs/286 b/tests/btrfs/286
index fb805256..f1ee129c 100755
--- a/tests/btrfs/286
+++ b/tests/btrfs/286
@@ -71,6 +71,9 @@ for t in "${_btrfs_profile_configs[@]}"; do
  	workload "$t"
  echo "Silence is golden"
# success, all done

Looks good.

Reviewed-by: Anand Jain <anand.jain@xxxxxxxxxx>

[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux