On Thu, Feb 23, 2023 at 3:56 PM Johannes Thumshirn <johannes.thumshirn@xxxxxxx> wrote: > > _require_scratch_dev_pool() zeros the first 100 sectors of each device to > clear eventual remains of older filesystems. > > On zoned devices this creates all sorts of problems, so just skip the > clearing there. What kind of problems? Can you give 1 or 2 examples at least? And it would be nice to comment in the code why we don't zero the sectors for zoned devices. Thanks. > > Signed-off-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx> > --- > common/rc | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/common/rc b/common/rc > index 654730b21ead..d763501be2b2 100644 > --- a/common/rc > +++ b/common/rc > @@ -3461,7 +3461,9 @@ _require_scratch_dev_pool() > fi > # to help better debug when something fails, we remove > # traces of previous btrfs FS on the dev. > - dd if=/dev/zero of=$i bs=4096 count=100 > /dev/null 2>&1 > + if [ "`_zone_type "$i"`" = "none" ]; then > + dd if=/dev/zero of=$i bs=4096 count=100 > /dev/null 2>&1 > + fi > done > } > > -- > 2.39.1 >
