Re: [PATCH] fstests: btrfs/249, add _wants_kernel_commit

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On 2/13/23 19:56, Filipe Manana wrote:
On Mon, Feb 13, 2023 at 9:58 AM Anand Jain <anand.jain@xxxxxxxxxx> wrote:

Add the _wants_kernel_commit tag for the benifit of testing on the older
kernels.

Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx>
---
  tests/btrfs/249 | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/btrfs/249 b/tests/btrfs/249
index 7cc4996e387b..1b79e52dbe05 100755
--- a/tests/btrfs/249
+++ b/tests/btrfs/249
@@ -13,7 +13,7 @@
  #  Dump 'btrfs filesystem usage', check it didn't fail
  #
  # Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch
-#   btrfs: sysfs add devinfo/fsid to retrieve fsid from the device
+#   btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device
  #   btrfs-progs: read fsid from the sysfs in device_is_seed

  . ./common/preamble
@@ -29,6 +29,8 @@ _supported_fs btrfs
  _require_scratch_dev_pool 3
  _require_command "$WIPEFS_PROG" wipefs
  _require_btrfs_forget_or_module_loadable
+_wants_kernel_commit a26d60dedf9a \
+       "btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device"

There's a btrfs-progs patch listed above, so you can also add a:

  _fixed_by_git_commit btrfs-progs xxxxxxxxxxxx "btrfs-progs: read fsid
from the sysfs in device_is_seed"

And with that, you can then remove the comment above with the patch
subjects, as it becomes redundant and pointless.


 Got it. Fixing in v2.

Thanks.

Thanks.


  _scratch_dev_pool_get 2
  # use the scratch devices as seed devices
--
2.31.1





[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux