Re: [PATCH] fstests: btrfs/249, add _wants_kernel_commit

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

On 2/14/23 14:17, Zorro Lang wrote:
On Mon, Feb 13, 2023 at 05:45:09PM +0800, Anand Jain wrote:
Add the _wants_kernel_commit tag for the benifit of testing on the older

Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx>

Besides this patch, you just sent another patchset:
   [PATCH 0/3] fstests: btrfs- add _fixed_by for new tests in the auto group
which try to add _fixed_by for some btrfs cases.

 Recently, these were added to the auto group.

I think we don't need to "fix" these things one by one, by lots of small patch


If there's not special reason (e.g. someone case need more fix besides
adding _fixed_by), how about combine them into one patch which "clarify the
_fixed_by or _wants commits for btrfs cases (or only for someone group)"

 btrfs/249 needs _wants_kernel_commit; btrfs/198, btrfs/185, and
 btrfs/219 need _fixed_by_kernel_commit. Merge the latter and
 send as one patch?

Thanks, Anand


  tests/btrfs/249 | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/btrfs/249 b/tests/btrfs/249
index 7cc4996e387b..1b79e52dbe05 100755
--- a/tests/btrfs/249
+++ b/tests/btrfs/249
@@ -13,7 +13,7 @@
  #  Dump 'btrfs filesystem usage', check it didn't fail
  # Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch
-#   btrfs: sysfs add devinfo/fsid to retrieve fsid from the device
+#   btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device
  #   btrfs-progs: read fsid from the sysfs in device_is_seed
. ./common/preamble
@@ -29,6 +29,8 @@ _supported_fs btrfs
  _require_scratch_dev_pool 3
  _require_command "$WIPEFS_PROG" wipefs
+_wants_kernel_commit a26d60dedf9a \
+	"btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device"
_scratch_dev_pool_get 2
  # use the scratch devices as seed devices

[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux