Re: [PATCH 6/7] generic: add 251 to the auto group

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Thu, Feb 09, 2023 at 06:13:54AM +0100, Christoph Hellwig wrote:
> generic/251 isn't dangerous, doesn't takes overly long to run and doesn't
> produce spurious failures, so add it to the auto group.

How long does it take for you?  It generally takes 300-700s to run on my
testing cloud.  That's not a reason to keep it out of the auto group,
but I've been surveying the long running tests to find the ones that run
stuff in a loop and subject them to TIME_FACTOR (or the new
SOAK_DURATION knob that I'm working on to allow direct control of loop
runtime) constraints.

--D

> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
>  tests/generic/251 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/251 b/tests/generic/251
> index 192ab5cc..2a271cd1 100755
> --- a/tests/generic/251
> +++ b/tests/generic/251
> @@ -10,7 +10,7 @@
>  # corrupts the filesystem (data/metadata).
>  #
>  . ./common/preamble
> -_begin_fstest ioctl trim
> +_begin_fstest ioctl trim auto
>  
>  tmp=`mktemp -d`
>  trap "_cleanup; exit \$status" 0 1 3
> -- 
> 2.39.1
> 



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux