Re: [PATCH] common: Chown mount even if already idmapped to account for remounts

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Fri, Feb 03, 2023 at 06:54:37PM +0100, Gabriel Niebler wrote:
> This is a logical consequence of introducing the chown check in _idmapped_mount,
> since now a read-only mount can be made idmapped successfully. But if the mount
> is then remounted rw the chown never happens, as _idmapped_mount sees that it's
> already idmapped and bows out early.
> 
> This patch fixes that by simply moving the chown ahead of the idmapped check,
> so it will be performed in any case, even on already idmapped mounts.
> 
> Signed-off-by: Gabriel Niebler <gniebler@xxxxxxxx>
> ---

Looks good to me,
Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>

Thanks!



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux