On Tue, Jan 31, 2023 at 01:54:16PM +0100, Jan Kara wrote:
> Test how the filesystem can handle moving a directory to a different
> directory (so that parent pointer gets updated) while it is grown. Ext4
> and UDF had a bug where if the directory got converted to a different
> type due to growth while rename is running, the filesystem got
> corrupted.
>
> Reviewed-by: Bill O'Donnell <bodonnel@xxxxxxxxxx>
> Signed-off-by: Jan Kara <jack@xxxxxxx>
> ---
Thanks, this version looks good to me,
Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>
> tests/generic/707 | 70 +++++++++++++++++++++++++++++++++++++++++++
> tests/generic/707.out | 2 ++
> 2 files changed, 72 insertions(+)
> create mode 100755 tests/generic/707
> create mode 100644 tests/generic/707.out
>
> diff --git a/tests/generic/707 b/tests/generic/707
> new file mode 100755
> index 000000000000..ad1592a1b957
> --- /dev/null
> +++ b/tests/generic/707
> @@ -0,0 +1,70 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2023 Jan Kara, SUSE Linux. All Rights Reserved.
> +#
> +# FS QA Test 707
> +#
> +# This is a test verifying whether the filesystem can gracefully handle
> +# modifying of a directory while it is being moved, in particular the cases
> +# where directory format changes
> +#
> +. ./common/preamble
> +_begin_fstest auto
> +
> +_supported_fs generic
> +_require_scratch
> +
> +_fixed_by_kernel_commit f950fd052913 \
> + "udf: Protect rename against modification of moved directory"
> +_fixed_by_kernel_commit XXXXXXXXXXXX \
> + "ext4: fix possible corruption when moving a directory"
> +
> +_scratch_mkfs >>$seqres.full 2>&1
> +_scratch_mount
> +
> +_cleanup()
> +{
> + cd /
> + rm -f $tmp.*
> + if [ -n "$BGPID" ]; then
> + # Stop background process
> + kill -9 $BGPID &>/dev/null
> + wait
> + fi
> +}
> +
> +# Loop multiple times trying to hit the race
> +loops=$((100*TIME_FACTOR))
> +files=500
> +moves=500
> +
> +create_files()
> +{
> + # We use slightly longer file name to make directory grow faster and
> + # hopefully convert between various types
> + for (( i = 0; i < $files; i++ )); do
> + touch somewhatlongerfilename$i
> + done
> +}
> +
> +for (( i = 0; i <= $moves; i++ )); do
> + mkdir $SCRATCH_MNT/dir$i
> +done
> +
> +for (( l = 0; l < $loops; l++ )); do
> + mkdir $SCRATCH_MNT/dir0/dir
> + pushd $SCRATCH_MNT/dir0/dir &>/dev/null
> + create_files &
> + BGPID=$!
> + popd &>/dev/null
> + for (( i = 0; i < $moves; i++ )); do
> + mv $SCRATCH_MNT/dir$i/dir $SCRATCH_MNT/dir$((i+1))/dir
> + done
> + wait
> + unset BGPID
> + rm -r $SCRATCH_MNT/dir$moves/dir
> +done
> +
> +echo "Silence is golden"
> +status=0
> +exit
> diff --git a/tests/generic/707.out b/tests/generic/707.out
> new file mode 100644
> index 000000000000..8e57a1d8c971
> --- /dev/null
> +++ b/tests/generic/707.out
> @@ -0,0 +1,2 @@
> +QA output created by 707
> +Silence is golden
> --
> 2.35.3
>
