Re: [PATCH] common: Improve blocksize support for udf

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Tue 31-01-23 00:54:23, Zorro Lang wrote:
> On Mon, Jan 23, 2023 at 10:38:00AM +0100, Jan Kara wrote:
> > Add better support for blocksize selection in _scratch_mkfs_sized
> > (accept another variant of mkfs options, select correct default block
> > size if not specified). Also add blocksize selection support to
> > _scratch_mkfs_blocksized.
> > 
> > For _check_udf_filesystem to keep working when blocksize is not
> > specified in MKFS_OPTIONS, add detection of blocksize from a mounted
> > filesystem.
> > 
> > Signed-off-by: Jan Kara <jack@xxxxxxx>
> > ---
> 
> Is this patch a replacement of below patch ?
>   [PATCH 1/2] common: Provide blocksize and ecclength to udf fsck

No, it is an addition on top of this - a reaction to your comment that
besides _check_udf_filesystem there are other places that could use better
handling of blocksize in UDF.

> Due to you've sent a patchset, and that 2nd patch has been reviewed but
> not merged:
>   [PATCH 2/2] common: Unmount udf filesystem prior checking
> 
> I'm not sure if you write this one singly to replace the 1st patch, or be a
> supplement. Can you send these 2 or 3 patches in one patchset :)

So all three patches are needed. I can resend them all in one series if it
helps you.

								Honza
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux