Hi,
On Wed, 11 Jan 2023 01:22:21 +0800, An Long wrote:
> Generally the tester need BTRFS_PROFILE_CONFIGS to test certain
> profiles. For example, skip raid56 as it's not supported.
>
> Signed-off-by: An Long <lan@xxxxxxxx>
> ---
> tests/btrfs/011 | 48 ++++++++++++++++++++++++++++++++++++++----------
> 1 file changed, 38 insertions(+), 10 deletions(-)
>
> diff --git a/tests/btrfs/011 b/tests/btrfs/011
> index 6c3d037f..b9d175d1 100755
> --- a/tests/btrfs/011
> +++ b/tests/btrfs/011
> @@ -22,6 +22,8 @@
> . ./common/preamble
> _begin_fstest auto replace volume
>
> +_btrfs_get_profile_configs
...
> + if [[ "${_btrfs_profile_configs[@]}" =~ "-m raid1 -d raid1" ]]; then
> + workout "-m raid1 -d raid1" 2 no 2048
> + fi
These regexes aren't anchored, so above could match "-m raid1 -d raid10"
- not a problem given current profiles, but still not ideal.
My preference would be to use a loop for filtering workout parameters
against _btrfs_profile_configs, e.g.
for i in "-m single -d single:1 no 64" \
"-m dup -d single:1 no 64" \
"-m dup -d single:1 cancel 1024" \
...; do
# confirm "${i%:*}" is in _btrfs_profile_configs...
workout "${i%:*}" ${i#*:}
done
Cheers, David
