Re: [PATCH v2] btrfs/012: check if ext4 is available

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Tue, Jan 10, 2023 at 07:52:16AM -0800, Johannes Thumshirn wrote:
> btrfs/012 is requiring ext4 support to test the conversion, but the test
> case is only checking if mkfs.ext4 is available, not if the filesystem
> driver is actually available on the test host.
> 
> Check if the driver is available as well, before trying to run the test.
> 
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>
> ---

Looks good to me,

Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>

>  tests/btrfs/012 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/btrfs/012 b/tests/btrfs/012
> index 60461a342545..d9faf81ce1ad 100755
> --- a/tests/btrfs/012
> +++ b/tests/btrfs/012
> @@ -31,6 +31,7 @@ _require_command "$E2FSCK_PROG" e2fsck
>  # ext4 does not support zoned block device
>  _require_non_zoned_device "${SCRATCH_DEV}"
>  _require_loop
> +_require_extra_fs ext4
>  
>  BLOCK_SIZE=`_get_block_size $TEST_DIR`
>  
> -- 
> 2.38.1
> 




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux