RE: [PATCH] xfs/243: add _require_scratch_delalloc()

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



Hi zorro,

Is it OK to merge the patch?

Best Regards,
Xiao Yang

-----Original Message-----
From: Zorro Lang <zlang@xxxxxxxxxx> 
Sent: 2022年11月24日 0:27
To: Yang, Xiao/杨 晓 <yangx.jy@xxxxxxxxxxx>
Cc: fstests@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] xfs/243: add _require_scratch_delalloc()

On Wed, Nov 23, 2022 at 10:21:23AM +0000, Xiao Yang wrote:
> xfs/243 requires the delalloc feature of XFS so return [not run] when 
> XFS with enabled DAX doesn't support it.
> 
> Signed-off-by: Xiao Yang <yangx.jy@xxxxxxxxxxx>
> ---

Looks good to me, this case starts to fail from xfs dax supports reflink.

Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>

>  tests/xfs/243 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/xfs/243 b/tests/xfs/243 index 8f0c5939..739efe4a 
> 100755
> --- a/tests/xfs/243
> +++ b/tests/xfs/243
> @@ -27,6 +27,7 @@ _begin_fstest auto quick clone punch  _supported_fs 
> xfs  _require_xfs_debug  _require_scratch_reflink
> +_require_scratch_delalloc
>  _require_xfs_io_command "falloc"
>  _require_xfs_io_command "cowextsize"
>  _require_xfs_io_command "fpunch"
> --
> 2.34.1
> 





[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux