Re: [PATCH] check: call _check_dmesg even if the test case failed

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



Hi Qu,

On Wed, 14 Dec 2022 08:08:31 +0800, Qu Wenruo wrote:

...
> index d2e5129620bd..487da43537ad 100755
> --- a/check
> +++ b/check
> @@ -950,6 +950,9 @@ function run_section()
>  			_scratch_unmount 2> /dev/null
>  			rm -f ${RESULT_DIR}/require_test*
>  			rm -f ${RESULT_DIR}/require_scratch*
> +			# Even we failed, there may be something interesting in
> +			# dmesg which can help debugging.

Nit: "Even though we ...", although the comment is probably unnecessary.

> +			_check_dmesg
>  			tc_status="fail"
>  		else
>  			# The test apparently passed, so check for corruption

Makes sense.
Reviewed-by: David Disseldorp <ddiss@xxxxxxx>



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux