Re: [PATCH] check: use /var/tmp instead of /tmp

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Mon, Dec 12, 2022 at 03:06:46PM -0800, Leah Rumancik wrote:
> With the results recorded in /tmp, a crashing test results in a loss
> of all prior test runs. Instead, record results in /var/tmp so that
> it is possible to recover results from completed tests.

RESULT_BASE=/some/stable/storage ./check <args> ?

> Also, make sure tmp.arglist is wiped before each run to avoid
> accidentally rerunning tests.
> 
> Signed-off-by: Leah Rumancik <leah.rumancik@xxxxxxxxx>
> ---
>  check | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/check b/check
> index d2e51296..21c00524 100755
> --- a/check
> +++ b/check
> @@ -4,7 +4,7 @@
>  #
>  # Control script for QA
>  #
> -tmp=/tmp/$$
> +tmp=/var/tmp/$$
>  status=0
>  needwrap=true
>  needsum=true
> @@ -46,7 +46,7 @@ export DIFF_LENGTH=${DIFF_LENGTH:=10}
>  # by default don't output timestamps
>  timestamp=${TIMESTAMP:=false}
>  
> -rm -f $tmp.list $tmp.tmp $tmp.grep $here/$iam.out $tmp.xlist $tmp.report.*
> +rm -f $tmp.list $tmp.tmp $tmp.grep $here/$iam.out $tmp.xlist $tmp.report.* $tmp.arglist

This part looks correct though.

--D

>  SRC_GROUPS="generic shared"
>  export SRC_DIR="tests"
> -- 
> 2.39.0.rc1.256.g54fd8350bd-goog
> 



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux