Re: supporting overlay+tmpfs breaks check -n -overlay -g auto

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On 2022/12/12 10:36, Gao Xiang wrote:
On Mon, Dec 12, 2022 at 10:08:33AM +0800, Baokun Li wrote:
On 2022/12/12 9:42, Murphy Zhou wrote:
Hi,

Bisecting points me to this commit:

commit 92fb58afaa2f38a9369ad5791a4cbf135545617d
Author: Baokun Li <libaokun1@xxxxxxxxxx>
Date:   Wed May 11 16:34:04 2022 +0800

      common: xfstests support overlay+tmpfs


It breaks this command:
./check -n -overlay -g auto

As a result, it fails to show me the list of testcases.

Please help to check.

Thanks!
Murphy
I tried to run the command on the latest version, and everything was fine.

Did I miss anything?

What is the version, environment, and config for reproducing the problem?

Just to mention that we've also encountered this issue by doing

FSTYP=ext4
./check -overlay generic/192

it seems the workaround would be:
1) add an environment variable: export OVL_BASE_FSTYP=ext4
or
2) update ./check and delete:

# Process command arguments first.
while [ $# -gt 0 ]; do
         case "$1" in
         -\? | -h | --help) usage ;;

         -nfs|-glusterfs|-cifs|-9p|-virtiofs|-pvfs2|-tmpfs|-ubifs)
                 FSTYP="${1:1}"
                 ;;
         -overlay)
                 FSTYP=overlay
                     ^ remove this
                 export OVERLAY=true
                 ;;>

Thanks,
Gao Xiang

I also tested this use case and the results are as follows, and the test is passed.

    [root@fedora xfstest]# export OVL_BASE_FSTYP=ext4
    [root@fedora xfstest]# ./check -overlay generic/192
    FSTYP         -- overlay
    PLATFORM      -- Linux/x86_64 fedora 5.10.0+ #571 SMP Sat Dec 10 16:41:36 CST 2022
    MKFS_OPTIONS  -- /tmp/scratch
    MOUNT_OPTIONS -- /tmp/scratch /tmp/scratch/ovl-mnt

    generic/192 7s ...  7s
    Ran: generic/192
    Passed all 1 tests

Can you provide a stable reproducer? Or provide the error information or
help track the location where return the error.
--
With Best Regards,
Baokun Li
.



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux