Re: [PATCH v2] add files to ignore & chmod 755 tests/generic/692

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Sat, Dec 10, 2022 at 02:31:05AM +0000, Shiyang Ruan wrote:
> 1. The executable binary in src/ should be in ignore file.
> 2. tests/xfs/216.out is a symlink generated at runtime, also should be
>    ignored.
> 3. tests/generic/692 was created with 644.  It should be 755 otherwise
>    its mode will be changed and dirty the git tree after test.
> 
> Signed-off-by: Shiyang Ruan <ruansy.fnst@xxxxxxxxxxx>
> Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>
> ---

Looks good to me, if no objection or better idea, I'd like change the subject
as below when I merge it:
  fstests: batch update of file mode and untracked files

Thanks,
Zorro

>  .gitignore        | 2 ++
>  tests/generic/692 | 0
>  2 files changed, 2 insertions(+)
>  mode change 100644 => 100755 tests/generic/692
> 
> diff --git a/.gitignore b/.gitignore
> index ad9f45437..a6f433f1d 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -79,6 +79,7 @@ tags
>  /src/dirstress
>  /src/e4compact
>  /src/ext4_resize
> +/src/fake-dump-rootino
>  /src/fault
>  /src/feature
>  /src/fiemap-tester
> @@ -205,6 +206,7 @@ tags
>  /tests/xfs/033.out
>  /tests/xfs/071.out
>  /tests/xfs/096.out
> +/tests/xfs/216.out
>  
>  # cscope files
>  cscope.*
> diff --git a/tests/generic/692 b/tests/generic/692
> old mode 100644
> new mode 100755
> -- 
> 2.38.1
> 




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux