Re: [PATCH] generic/614: Run test only for filesystems supporting delalloc

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Tue, Nov 22, 2022 at 2:12 PM Jan Kara <jack@xxxxxxx> wrote:
>
> Simple filesystems such as ext2 or udf do not support delayed
> allocation. Thus they allocate data blocks for mmap writes only during
> writeback. This makes test generic/614 fail because it checks exactly
> whether the blocks for the write are reserved before writeback happens.
> Make the test depend on delayed allocation support.
>
> Signed-off-by: Jan Kara <jack@xxxxxxx>

Looks good. I wasn't aware that a _require_scratch_delalloc helper
existed already.

Reviewed-by: Filipe Manana <fdmanana@xxxxxxxx>

Thanks.

> ---
>  tests/generic/614 | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/generic/614 b/tests/generic/614
> index 06630f2249c7..3e2a587c8f90 100755
> --- a/tests/generic/614
> +++ b/tests/generic/614
> @@ -16,6 +16,7 @@ _begin_fstest auto quick rw
>  # real QA test starts here
>  _supported_fs generic
>  _require_scratch
> +_require_scratch_delalloc
>
>  _scratch_mkfs >>$seqres.full 2>&1
>  _scratch_mount
> --
> 2.35.3
>



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux