On Fri, Nov 11, 2022 at 09:58:35AM +0800, Zorro Lang wrote: > On Wed, Nov 09, 2022 at 02:32:42AM +0800, Zorro Lang wrote: > > When a test case requires someone xfs_io command, that nearly means > > that case belong that kind of test group. Likes fpunch for punch > > group, fcollapse for collapse group, falloc for prealloc group, fzero > > for zero group and so on. > > > > Many fstests cases miss some test groups they should belong to, so > > this patch trys to supplement this lack, according to the "xxxx" > > which required by _require_xfs_io_command "xxxx". > > > > Reported-by: Theodore Ts'o <tytso@xxxxxxx> > > Signed-off-by: Zorro Lang <zlang@xxxxxxxxxx> > > --- > > > > Hi, > > > > Ted complains the insert and collapse groups missing [1], cause he > > have to skip some cases by command of _require_xfs_io_command. > > > > I think the group missing is the real problem and the first problem, > > so I'm trying to add missed groups to fstests cases, simply according > > to _require_xfs_io_command lines. > > > > By a simple grep, I found there're too many cases contain _require_xfs_io_command, > > so I wrote a ugly temporary script to help to do this job automatically as [2]. > > This script is not good enough, so I took a little time to do manual checking > > after running the script. Hope this patch helps, feel free to review or test, > > and please tell me if I miss something. > > Any comments about this change? I'm not asking for reviewing that script, > just the group names change :) > > Thanks, > Zorro > The changes looks good to me (also did some manual checking). Reviewed-by: Andrey Albershteyn <aalbersh@xxxxxxxxxx> But otherwise, I think, as it's in shape now it's more work for reviewer - to check those groups, as it could be done automatically maybe it make sense to add similar script to build system, maybe? :) Btw, which commands are considered to have their own group? pwrite, for example, doesn't have a group (so, those tests aren't changed). -- - Andrey
