On Sat, Nov 05, 2022 at 02:29:18PM -0400, Theodore Ts'o wrote: > From: Eric Whitney <enwlinux@xxxxxxxxx> > > generic/455 fails when run on an ext4 bigalloc file system. Its > fsx invocations can make insert range and collapse range calls whose > arguments are not cluster aligned, and ext4 will fail those calls for > bigalloc. They can be suppressed by adding the FSX_AVOID environment > variable to the fsx invocation and setting its value appropriately in > the test environment, as is done for other fsx-based tests. This > avoids the need to exclude the test to avoid failures and makes it > possible to take advantage of the remainder of its coverage. > > [ Also fix generic/457, as requested by Dave Chinner -- TYT] > > Signed-off-by: Eric Whitney <enwlinux@xxxxxxxxx> > Signed-off-by: Theodore Ts'o <tytso@xxxxxxx> > Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> > --- > > This is a respin of "generic/455: add $FSX_AVOID" which Eric posted here: > https://lore.kernel.org/r/20221021211950.510006-1-enwlinux@xxxxxxxxx > it adds a similar fix for generic/457, as requested by Dave and Zorro. Thanks Ted, actually I'm going to merge this patch (with g/457 fix by myself) this week. But looks like you missed the change on g/457 (might forgot to commit). Anyway, I think it's not worth wasting one more week for this small change, I'll help to change g/457 when I merge this patch. Thanks, Zorro > > tests/generic/455 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/generic/455 b/tests/generic/455 > index 649b54108..c13d872c6 100755 > --- a/tests/generic/455 > +++ b/tests/generic/455 > @@ -77,7 +77,7 @@ FSX_OPTS="-N $NUM_OPS -d -P $SANITY_DIR -i $LOGWRITES_DMDEV" > seeds=(0 0 0 0) > # Run fsx for a while > for j in `seq 0 $((NUM_FILES-1))`; do > - run_check $here/ltp/fsx $FSX_OPTS -S ${seeds[$j]} -j $j $SCRATCH_MNT/testfile$j & > + run_check $here/ltp/fsx $FSX_OPTS $FSX_AVOID -S ${seeds[$j]} -j $j $SCRATCH_MNT/testfile$j & > done > wait > > -- > 2.31.0 >
