Re: [xfstests PATCH 2/3] generic/577: add missing file removal before empty file test

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Thu, Nov 03, 2022 at 11:47:41PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> The fix for _fsv_have_hash_algorithm() exposed a bug where one of the
> test cases in generic/577 isn't deleting the file from the previous test
> case before it tries to write to it.  That causes a failure, since due
> to the fix for _fsv_have_hash_algorithm(), the file from the previous
> test case now ends up with verity enabled and therefore cannot be
> written to.  Fix this by deleting the file.
> 
> Reported-by: Andrey Albershteyn <aalbersh@xxxxxxxxxx>
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> ---
>  tests/generic/577 | 1 +
>  1 file changed, 1 insertion(+)
> 

Looks good.
Reviewed-by: Andrey Albershteyn <aalbersh@xxxxxxxxxx>

-- 
- Andrey




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux