Re: [PATCH v2] encrypt: add ceph support

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]




On 27/10/2022 11:20, Zorro Lang wrote:
On Thu, Oct 27, 2022 at 11:00:21AM +0800, xiubli@xxxxxxxxxx wrote:
From: Xiubo Li <xiubli@xxxxxxxxxx>

Signed-off-by: Xiubo Li <xiubli@xxxxxxxxxx>
---
  common/encrypt | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/common/encrypt b/common/encrypt
index 45ce0954..1a77e23b 100644
--- a/common/encrypt
+++ b/common/encrypt
@@ -153,6 +153,9 @@ _scratch_mkfs_encrypted()
  		# erase the UBI volume; reformated automatically on next mount
  		$UBIUPDATEVOL_PROG ${SCRATCH_DEV} -t
  		;;
+	ceph)
+		_scratch_cleanup_files

Here I just skip ceph and it is enough. Because the _require_scratch_encryption() will do the same thing as I did in my V1's 2/2 patch.

- Xiubo

+		;;
Any commits about that?

Sorry I'm not familar with cephfs, is this patch enough to help ceph to test
encrypted ceph? Due to you tried to do some "checking" job last time.

Can "./check -g encrypt" work on ceph? May you paste this test result to help
to review? And welcome review points from ceph list.

Thanks,
Zorro

[1]
$ grep -rsn _scratch_mkfs_encrypted tests/generic/
tests/generic/395:22:_scratch_mkfs_encrypted &>> $seqres.full
tests/generic/396:21:_scratch_mkfs_encrypted &>> $seqres.full
tests/generic/580:23:_scratch_mkfs_encrypted &>> $seqres.full
tests/generic/581:36:_scratch_mkfs_encrypted &>> $seqres.full
tests/generic/595:35:_scratch_mkfs_encrypted &>> $seqres.full
tests/generic/613:29:_scratch_mkfs_encrypted &>> $seqres.full
tests/generic/621:57:_scratch_mkfs_encrypted &>> $seqres.full
tests/generic/429:36:_scratch_mkfs_encrypted &>> $seqres.full
tests/generic/397:28:_scratch_mkfs_encrypted &>> $seqres.full
tests/generic/398:28:_scratch_mkfs_encrypted &>> $seqres.full
tests/generic/421:24:_scratch_mkfs_encrypted &>> $seqres.full
tests/generic/440:29:_scratch_mkfs_encrypted &>> $seqres.full
tests/generic/419:29:_scratch_mkfs_encrypted &>> $seqres.full
tests/generic/435:33:_scratch_mkfs_encrypted &>> $seqres.full
tests/generic/593:24:_scratch_mkfs_encrypted &>> $seqres.full
tests/generic/576:34:_scratch_mkfs_encrypted_verity &>> $seqres.full

  	*)
  		_notrun "No encryption support for $FSTYP"
  		;;
--
2.31.1





[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux