On Tue, Oct 25, 2022 at 10:58:01AM +0800, Zorro Lang wrote:
> On Mon, Oct 24, 2022 at 11:35:24AM +0200, Lukas Czerner wrote:
> > Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>
> > ---
> > tests/generic/219 | 1 +
> > tests/generic/252 | 1 +
> > tests/generic/446 | 1 +
> > tests/generic/459 | 1 +
> > tests/generic/569 | 1 +
> > tests/generic/570 | 1 +
> > tests/generic/587 | 1 +
> > 7 files changed, 7 insertions(+)
> >
> > diff --git a/tests/generic/219 b/tests/generic/219
> > index d3d257f1..71da25e3 100755
> > --- a/tests/generic/219
> > +++ b/tests/generic/219
> > @@ -20,6 +20,7 @@ _require_scratch
> > _require_quota
> > _require_user
> > _require_group
> > +_require_odirect
> >
> > test_files()
> > {
> > diff --git a/tests/generic/252 b/tests/generic/252
> > index 8c5adb53..b35833ba 100755
> > --- a/tests/generic/252
> > +++ b/tests/generic/252
> > @@ -27,6 +27,7 @@ _require_scratch
> > _require_dm_target error
> > _require_xfs_io_command "falloc"
> > _require_aiodio "aiocp"
> > +_require_odirect
>
> I think this's a duplication, due to _require_aiodio already contains
> the _require_odirect. Do you hit any failure on this test?
Ah, you're right. I'll resend the patch.
Thanks!
-Lukas
>
> Others make sense to me.
>
> Thanks,
> Zorro
>
> > AIO_TEST="$here/src/aio-dio-regress/aiocp"
> >
> > # Disable the scratch rt device to avoid test failures relating to the rt
> > diff --git a/tests/generic/446 b/tests/generic/446
> > index 5f2d2edd..b69502cb 100755
> > --- a/tests/generic/446
> > +++ b/tests/generic/446
> > @@ -21,6 +21,7 @@ _begin_fstest auto quick rw punch
> > _require_scratch
> > _require_xfs_io_command "truncate"
> > _require_xfs_io_command "fpunch"
> > +_require_odirect
> >
> > # format and mount
> > _scratch_mkfs > $seqres.full 2>&1
> > diff --git a/tests/generic/459 b/tests/generic/459
> > index 7be39089..4dd7a43b 100755
> > --- a/tests/generic/459
> > +++ b/tests/generic/459
> > @@ -47,6 +47,7 @@ _require_dm_target snapshot
> > _require_command $LVM_PROG lvm
> > _require_command "$THIN_CHECK_PROG" thin_check
> > _require_freeze
> > +_require_odirect
> >
> > vgname=vg_$seq
> > lvname=lv_$seq
> > diff --git a/tests/generic/569 b/tests/generic/569
> > index c5dcfefe..eeaf3f16 100755
> > --- a/tests/generic/569
> > +++ b/tests/generic/569
> > @@ -25,6 +25,7 @@ _supported_fs generic
> > _require_xfs_io_command "falloc"
> > _require_test_program swapon
> > _require_scratch_swapfile
> > +_require_odirect
> >
> > _scratch_mkfs > $seqres.full 2>&1
> > _scratch_mount >> $seqres.full 2>&1
> > diff --git a/tests/generic/570 b/tests/generic/570
> > index 126b222d..2143c742 100755
> > --- a/tests/generic/570
> > +++ b/tests/generic/570
> > @@ -25,6 +25,7 @@ _supported_fs generic
> > _require_test_program swapon
> > _require_scratch_nocheck
> > _require_block_device $SCRATCH_DEV
> > +_require_odirect
> > # We cannot create swap on a zoned device because it can cause random write IOs
> > _require_non_zoned_device "$SCRATCH_DEV"
> > test -e /dev/snapshot && _notrun "userspace hibernation to swap is enabled"
> > diff --git a/tests/generic/587 b/tests/generic/587
> > index 19b047ac..ebfeea1d 100755
> > --- a/tests/generic/587
> > +++ b/tests/generic/587
> > @@ -25,6 +25,7 @@ _require_user
> > _require_quota
> > _require_xfs_io_command "falloc"
> > _require_scratch
> > +_require_odirect
> >
> > cat > $tmp.awk << ENDL
> > {
> > --
> > 2.37.3
> >
>
