Re: [PATCH] fstests: add btrfs tests exercising raid to the raid group

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On 18.10.22 20:26, Luis Chamberlain wrote:
> On Mon, Oct 17, 2022 at 01:53:17AM -0700, Johannes Thumshirn wrote:
>> Several tests for btrfs exercise the raid code, but are not added to the
>> raid group. Most of these tests pull in raid via
>> '_btrfs_get_profile_configs()'.
>>
>> Other tests have a '_require_btrfs_fs_feature raid56' which also pulls in
>> raid, but are not added to the raid group.
>>
>> Reported-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>
>> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>
> 
> Shouldn't we have a raid56 group alone too? Then distros that simply
> don't support it can skip those tests.
>  
>   Luis
> 

If it's just for skipping RAID56 alone, I think adjusting the 
${BTRFS_PROFILE_CONFIGS[@]} environment variable is a better choice.




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux