on 2022/10/17 23:04, Christian Brauner wrote: > On Mon, Oct 17, 2022 at 09:29:14PM +0800, Zorro Lang wrote: >> On Mon, Oct 17, 2022 at 10:01:13AM +0000, xuyang2018.jy@xxxxxxxxxxx wrote: >>> >>> >>> on 2022/10/17 17:53, Christian Brauner wrote: >>>> This test changes permissions and specifically tests for setuid and >>>> setgid bits to be dropped or kept. It really needs to be run when -g >>>> perms is specified. >>> >>> Yes, Reviewed-by: Yang Xu <xuyang2018.jy@xxxxxxxxxxx> >>> >>> ps: generic/67[3-4] and generic/68[3-7] test suid and sgid, they should >>> also add perms group. >> >> OK, if Christian agrees with this point and would like to help that, please >> help to check and add "perms" to more proper cases in one patch. > > I think that's a good idea. Yang, would you be open to sending a patch > to add all these test to the "perms" group in one go? Of course, I will look for more case to add perms group in one patch as zorro and you sugguested. Best Regards Yang Xu
