Re: [PATCH 6/6] common/populate: fix _xfs_metadump usage in _scratch_populate_cached

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, Oct 05, 2022 at 03:31:06PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
> 
> _xfs_metadump requires that the caller pass in "none" for the log device
> if it doesn't have a log device, so fix this call site.
> 
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> ---

Good to me,
Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>

>  common/populate |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff --git a/common/populate b/common/populate
> index 4eee7e8c66..cfdaf766f0 100644
> --- a/common/populate
> +++ b/common/populate
> @@ -891,7 +891,7 @@ _scratch_populate_cached() {
>  		_scratch_xfs_populate $@
>  		_scratch_xfs_populate_check
>  
> -		local logdev=
> +		local logdev=none
>  		[ "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_LOGDEV" ] && \
>  			logdev=$SCRATCH_LOGDEV
>  
> 




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux