on 2022/08/28 10:48, Zorro Lang wrote: > On Wed, Aug 17, 2022 at 11:10:23AM +0800, Yang Xu wrote: >> Plan to remove noacl and nouser_xattr mount option in kernel because they >> are deprecated[1]. So remove nouser_xattr test in here. > > What's the [1]? > > We'd better to be careful when we want to remove a testing coverage. I'm not > sure if they've decided to removed this mount option, the ext4/053 is an > important test case for ext4, so I'd like to hear their opinion. Sorry for this miss. [1]https://lore.kernel.org/linux-ext4/1658977369-2478-1-git-send-email-xuyang2018.jy@xxxxxxxxxxx/T/#t Best Regards Yang Xu > > Thanks, > Zorro > >> >> Reported-by: kernel test robot <oliver.sang@xxxxxxxxx> >> Signed-off-by: Yang Xu <xuyang2018.jy@xxxxxxxxxxx> >> --- >> tests/ext4/053 | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/tests/ext4/053 b/tests/ext4/053 >> index 555e474e..5d2c478a 100755 >> --- a/tests/ext4/053 >> +++ b/tests/ext4/053 >> @@ -439,7 +439,6 @@ for fstype in ext2 ext3 ext4; do >> mnt oldalloc removed >> mnt orlov removed >> mnt -t user_xattr >> - mnt nouser_xattr >> >> if _has_kernel_config CONFIG_EXT4_FS_POSIX_ACL; then >> mnt -t acl >> -- >> 2.27.0 >> >
