On 8/3/22 18:40, Zorro Lang wrote: > On Wed, Aug 03, 2022 at 06:48:47AM +0000, liuyd.fnst@xxxxxxxxxxx wrote: >> Hi Zorro >> >> On 8/2/22 17:17, Zorro Lang wrote: >>> On Tue, Aug 02, 2022 at 07:52:40AM +0000, Liu Yiding wrote: >>>> This test require security attr. Skip test if fs doesn't support >>>> security attr. E.g. virtiofs >>>> >>>> Signed-off-by: Liu Yiding <liuyd.fnst@xxxxxxxxxxx> >>>> --- >>> >>> Hmm... looks like we can re-start this discussion long time ago: >>> >>> https://lore.kernel.org/fstests/20220323023845.saj5en74km7aibdx@zlang-mailbox/ >>> >>> About how can we deal with those fs doesn't support capabilities, e.g. nfs, virtiofs?? >> >> Ahh, so I don't need to send a v2 patch until you finish above discussion. > > Actually I'm not sure if we need a _require_capabilities(), or just use > "_require_attrs security" for all filesystems which support/unsupport > capabilities. Hope to hear more points. > I think a _require_capabilities() is much better than "_require_attrs security()". > If you'd like to send v2, there's not only g/688 need capabilities. > > Thanks, > Zorro > >> >>> >>> Thanks, >>> Zorro >>> >>>> tests/generic/688 | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/tests/generic/688 b/tests/generic/688 >>>> index 426286b6..d11b4c21 100755 >>>> --- a/tests/generic/688 >>>> +++ b/tests/generic/688 >>>> @@ -7,6 +7,7 @@ >>>> # Functional test for dropping capability bits as part of an fallocate. >>>> # >>>> . ./common/preamble >>>> +. ./common/attr >>>> _begin_fstest auto prealloc quick >>>> >>>> # Override the default cleanup function. >>>> @@ -28,6 +29,7 @@ _require_command "$GETCAP_PROG" getcap >>>> _require_command "$SETCAP_PROG" setcap >>>> _require_xfs_io_command falloc >>>> _require_test >>>> +_require_attrs security >>>> _require_congruent_file_oplen $TEST_DIR 65536 >>>> >>>> junk_dir=$TEST_DIR/$seq >>>> -- >>>> 2.34.1 >>>> >
