Re: [PATCH] btrfs/253: skip on zoned mode as we cannot change the chunk size

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Tue, Jul 26, 2022 at 04:57:59PM +0900, Naohiro Aota wrote:
> On zoned mode, we have a fixed chunk size which is equal to the zone size.
> So, we cannot change the chunk size, and running this test results in a
> failure with below.
> 
>     --- tests/btrfs/253.out     2021-12-10 04:33:53.000000000 +0000
>     +++ /host/results/btrfs/253.out.bad 2022-07-26 05:58:10.000000000 +0000
>     @@ -2,9 +2,16 @@
>      Capture default chunk sizes.
>      First allocation.
>      Second allocation.
>     +./common/rc: line 4670: echo: write error: Invalid argument
>     +./common/rc: line 4670: echo: write error: Invalid argument
>      Calculate request size so last memory allocation cannot be completely fullfilled.
>      Third allocation.
>     ...
> 
> It is no use to test this feature on zoned mode. So, just skip it.
> 
> Signed-off-by: Naohiro Aota <naohiro.aota@xxxxxxx>
> ---

Make sense to me,

Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>

>  tests/btrfs/253 | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/btrfs/253 b/tests/btrfs/253
> index fbbb81fae754..c746f41e9264 100755
> --- a/tests/btrfs/253
> +++ b/tests/btrfs/253
> @@ -81,6 +81,8 @@ alloc_size() {
>  _supported_fs btrfs
>  _require_test
>  _require_scratch
> +# The chunk size on zoned mode is fixed to the zone size
> +_require_non_zoned_device "$SCRATCH_DEV"
>  
>  # Delete log file if it exists.
>  rm -f "${seqres}.full"
> -- 
> 2.35.1
> 




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux