On Sun, Jul 24, 2022 at 5:07 PM Zorro Lang <zlang@xxxxxxxxxx> wrote: > > On Thu, Jul 14, 2022 at 06:30:10PM +0200, Amir Goldstein wrote: > > Sorry for off list email > > Please add to whiteout group > > Oh, sure, thanks! > > The "whiteout" group name is described as (in doc/group-names.txt): > > whiteout overlayfs whiteout functionality > > I think it's not an overlayfs specific group, how about remove the > "overlayfs" prefix? The whiteout inode is a vfs construct that was introduced for overlayfs: RENAME_WHITEOUT (since Linux 3.18) This operation makes sense only for overlay/union filesystem implementations. There is no other known usage for whiteout inode. You could remove the "overlayfs" prefix, but that would just make the whiteout context less clear IMO. > > BTW, is there anything wrong (about secret?) with this test case, to make > you have to off list email. This looks like a normal review point ;) > Nope, just a technical issue when replying from my mobile. Thanks, Amir.