On Wed, Jul 20, 2022 at 12:43:56PM -0400, Theodore Ts'o wrote: > This test tests log recovery by kicking off fstress on the scratch fs, > then switching out the underlying the device with dm-error to see what > happens when the disk goes down. But when there is an external log > device writes to the log device still succeed, while writes to the > rest of the file system fail, and this leads to file system > corruption. So skip this test when there is an external log. Hm, could you review the congruent operation length series[1], please? Once that's done, I can move on to the next push, which is fixing up dmerror[2] and fail-make-request[3] to handle external devices: [1] https://lore.kernel.org/fstests/165826663647.3249494.13640199673218669145.stgit@magnolia/T/#t [2] https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfstests-dev.git/log/?h=dmerror-on-rt-devices [3] https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfstests-dev.git/log/?h=fix-fail-make-reqest --D > Signed-off-by: Theodore Ts'o <tytso@xxxxxxx> > --- > tests/generic/475 | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tests/generic/475 b/tests/generic/475 > index c426402e..43c26303 100755 > --- a/tests/generic/475 > +++ b/tests/generic/475 > @@ -34,6 +34,10 @@ _require_scratch > _require_dm_target error > _require_command "$KILLALL_PROG" "killall" > > +if test "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_LOGDEV" ; then > + _notrun "Cannot have external log device" > +fi > + > echo "Silence is golden." > > _scratch_mkfs >> $seqres.full 2>&1 > -- > 2.31.0 >
