Without xfsprogs commit f4afdcb0a ("xfs_db: clean up the salvage read callsites in set_cur()"), this case will fail as below: +/var/lib/xfstests/tests/xfs/270: line 51: [: !=: unary operator expected With this xfsprogs bug, xfs_db can't get new_ro_compat value, so report this bash syntax error. Fix this and add a helper output for xfsprogs bug. Signed-off-by: Yang Xu <xuyang2018.jy@xxxxxxxxxxx> --- tests/xfs/270 | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/xfs/270 b/tests/xfs/270 index b740c379..4954e943 100755 --- a/tests/xfs/270 +++ b/tests/xfs/270 @@ -47,9 +47,12 @@ _scratch_xfs_set_metadata_field "features_ro_compat" "$ro_compat" "sb 0" \ new_ro_compat=$(_scratch_xfs_get_metadata_field "features_ro_compat" "sb 0" \ 2>/dev/null) -# verify the new ro_compat field is correct. -if [ $new_ro_compat != $ro_compat ]; then +# verify the new ro_compat field is correct. Without xfsprogs commit +# f4afdcb0ad ("xfs_db: clean up the salvage read callsites in set_cur()"), +# we can't get new_ro_compat value. +if [ "$new_ro_compat" != "$ro_compat" ]; then echo "Unable to set new features_ro_compat. Wanted $ro_compat, got $new_ro_compat" + echo "May hit a known xfsprog bug" fi # rw mount with unknown ro-compat feature should fail -- 2.27.0