On Sat, Jun 25, 2022 at 12:39:27PM -0400, Theodore Ts'o wrote: > On Fri, Jun 24, 2022 at 12:08:25AM +0800, An Long wrote: > > > > +# check the size value in $MKFS_OPTIONS is an integer > > +if [[ $MKFS_OPTIONS =~ [0-9]+[^0-9\ ] ]] ; then > > + _fatal "error: \$MKFS_OPTIONS: Only number in bytes is allowed, no units." > > +fi > > This will break configs, since ext4 has a feature 64bit, so there > might be MKFS_OPTIONS that contain "-O 64bit", or "-O ^64bit". > > For that matter, this wll also break things like "-E encoding=12.1" > which sets the Unicode encoding to 12.1. > > ... or "-E lazy_itable_init=1,lazy_journal_init=1". > > Bottom line, blindly assuming that any number followed by a non-number > is a unit, is just not going to work. > > I think the real problem is that we have fstests trying to parse > MKFS_OPTIONS at all in the first place. Yup. That's exactly the issue. > For that matter, I'm not fond > of tests that try to override MKFS_OPTIONS for their own nefarious > purposes, because sometimes certain MKFS_OPTIONS imply something about > what must be in MOUNT_OPTIONS, or vice versa. I do understand why > that has to be done for certain tests, but... yelch. Especially in > centralized functions like _scratch_mkfs_sized, it just leads to tech > debt. > > I'll note that generic tests and functions in common/rc that do unholy > things with MKFS_OPTIONS already have to have per-file system hacks as > it is. So having more per-file system hacks for check_block_options() > is par for the course, so long as we accept that we want to have > generic tests and generic code violate the abstraction barrier and try > to read or override MKFS_OPTIONS. > > If we want to go down that approach, perhaps another approach would be > to specify the desired blocksize diretly in the fs config. Something > like "FS_BLOCK_SIZE=1024"? We can then have the fs-specific mkfs > commands translate that into the appropriate "-b 1024" or whatever > else might be appropriate for a particular file system. And then > tests that want to override the block size can just override > FS_BLOCK_SIZE and then the _mkfs function can use it as appropriate. This is the right way to fix the problem. My plan was that once there was a single point of checking of MKFS_OPTIONS, I'd use that to extract the default value ifor the entire fstests run and convert everything else to use it. And then add config section support for the variable so that it can easily be specified on a config section by section basis. I started writing an email that said exactly this, but then decided half way through that it was a waste of time because people would just nod, go their own way and yet again nothing would happen unless I did it myself.... -Dave. -- Dave Chinner david@xxxxxxxxxxxxx
