Re: [PATCH 1/6] check: avoid FSTYP=<fstyp parameter> repetition

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Mon, Jun 20, 2022 at 09:29:29PM +0200, David Disseldorp wrote:
> Signed-off-by: David Disseldorp <ddiss@xxxxxxx>
> ---
>  check | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/check b/check
> index de11b37e..42925e09 100755
> --- a/check
> +++ b/check
> @@ -277,15 +277,13 @@ while [ $# -gt 0 ]; do
>  	case "$1" in
>  	-\? | -h | --help) usage ;;
>  
> -	-nfs)		FSTYP=nfs ;;
> -	-glusterfs)	FSTYP=glusterfs ;;
> -	-cifs)		FSTYP=cifs ;;
> -	-9p)		FSTYP=9p ;;
> -	-virtiofs)	FSTYP=virtiofs ;;
> -	-overlay)	FSTYP=overlay; export OVERLAY=true ;;
> -	-pvfs2)		FSTYP=pvfs2 ;;
> -	-tmpfs)		FSTYP=tmpfs ;;
> -	-ubifs)		FSTYP=ubifs ;;
> +	-nfs|-glusterfs|-cifs|-9p|-virtiofs|-pvfs2|-tmpfs|-ubifs)
> +		FSTYP="${1:1}"
> +		;;
> +	-overlay)
> +		FSTYP=overlay
> +		export OVERLAY=true
> +		;;

Looks good.

Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>

>  
>  	-g)	group=$2 ; shift ;
>  		GROUP_LIST="$GROUP_LIST ${group//,/ }"
> -- 
> 2.35.3
> 




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux