On Thu, May 26, 2022 at 05:57:04PM +0800, Zorro Lang wrote:
> The lastest mount command (from util-linux) merged below commit:
> 79534c0d7e0f ("mount: add hint about dmesg(8) to error messages")
> which brought in a new error output when mount fails.
>
> That cause some cases (e.g. xfs/005) fail as:
> mount: Structure needs cleaning
> dmesg(1) may have more information after failed mount system call
>
> More failed cases like generic/050, ext4/002, xfs/154, etc ...
>
> Signed-off-by: Zorro Lang <zlang@xxxxxxxxxx>
> ---
>
> Due to _try_scratch_mount is call in many places, so I'm not sure if it's good
> to filter this message in _try_scratch_mount. Maybe better to filter it in each
> failed cases? Or write another function (e.g. _try_scratch_mount_fail) ?
> Welcome review points.
>
> Thanks,
> Zorro
>
> common/rc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/common/rc b/common/rc
> index 70a15f9c..67342760 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -335,7 +335,8 @@ _try_scratch_mount()
> _overlay_scratch_mount $*
> return $?
> fi
> - _mount -t $FSTYP `_scratch_mount_options $*`
> + _mount -t $FSTYP `_scratch_mount_options $*` 2> \
> + >(grep -v "dmesg(1) may have more information after failed mount" >&2)
_filter_error_mount()?
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
