Re: [PATCH v2 2/2] tests: remove redundant common/$FSTYP importing

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Thu, May 26, 2022 at 9:47 AM Zorro Lang <zlang@xxxxxxxxxx> wrote:
>
> As fstests intensively source specific common/$FSTYP files in
> common/rc, at the beginning of ./check running. Each single case
> doesn't need to import that again.
>
> Signed-off-by: Zorro Lang <zlang@xxxxxxxxxx>
> ---

Looks fine.

Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx>

>
> I removed "./common/filter" in btrfs/258 uncarefully, fix that in this V2.
>
> Thanks,
> Zorro
>
>  tests/btrfs/177 | 1 -
>  tests/btrfs/258 | 1 -
>  tests/btrfs/259 | 1 -
>  tests/xfs/422   | 1 -
>  tests/xfs/423   | 1 -
>  tests/xfs/517   | 1 -
>  6 files changed, 6 deletions(-)
>
> diff --git a/tests/btrfs/177 b/tests/btrfs/177
> index 2fd11e89..7b004b83 100755
> --- a/tests/btrfs/177
> +++ b/tests/btrfs/177
> @@ -10,7 +10,6 @@
>  _begin_fstest auto quick swap balance
>
>  . ./common/filter
> -. ./common/btrfs
>
>  # Modify as appropriate.
>  _supported_fs btrfs
> diff --git a/tests/btrfs/258 b/tests/btrfs/258
> index 158eaf79..da073333 100755
> --- a/tests/btrfs/258
> +++ b/tests/btrfs/258
> @@ -10,7 +10,6 @@
>  . ./common/preamble
>  _begin_fstest auto defrag quick
>
> -. ./common/btrfs
>  . ./common/filter
>
>  # real QA test starts here
> diff --git a/tests/btrfs/259 b/tests/btrfs/259
> index e7bd8ddd..92d0b9a6 100755
> --- a/tests/btrfs/259
> +++ b/tests/btrfs/259
> @@ -12,7 +12,6 @@ _begin_fstest auto quick defrag
>
>  # Import common functions.
>  . ./common/filter
> -. ./common/btrfs
>
>  # real QA test starts here
>
> diff --git a/tests/xfs/422 b/tests/xfs/422
> index 77db492e..175253aa 100755
> --- a/tests/xfs/422
> +++ b/tests/xfs/422
> @@ -17,7 +17,6 @@ _register_cleanup "_cleanup" BUS
>  . ./common/filter
>  . ./common/fuzzy
>  . ./common/inject
> -. ./common/xfs
>
>  # real QA test starts here
>  _supported_fs xfs
> diff --git a/tests/xfs/423 b/tests/xfs/423
> index be56f311..c9dfaece 100755
> --- a/tests/xfs/423
> +++ b/tests/xfs/423
> @@ -18,7 +18,6 @@ _register_cleanup "_cleanup" BUS
>  . ./common/filter
>  . ./common/fuzzy
>  . ./common/inject
> -. ./common/xfs
>
>  # real QA test starts here
>  _supported_fs xfs
> diff --git a/tests/xfs/517 b/tests/xfs/517
> index 512f795f..88c4f43b 100755
> --- a/tests/xfs/517
> +++ b/tests/xfs/517
> @@ -23,7 +23,6 @@ _cleanup()
>  . ./common/filter
>  . ./common/fuzzy
>  . ./common/inject
> -. ./common/xfs
>
>  # real QA test starts here
>  _supported_fs xfs
> --
> 2.31.1
>



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux